CMake: Additional target ALIAS in the VulkanMemoryAllocator namespace#522
Closed
M2-TE wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
Closed
CMake: Additional target ALIAS in the VulkanMemoryAllocator namespace#522M2-TE wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
M2-TE wants to merge 1 commit intoGPUOpen-LibrariesAndSDKs:masterfrom
Conversation
Contributor
|
Thank you for this improvement. I merged it into my fork for now: |
Contributor
Author
|
Since this was closed, was the PR rejected or will it simply be brought in as part of the fork from @sawickiap as planned? |
Contributor
|
It will be merged to the upstream repo soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title, this simply adds the new alias
VulkanMemoryAllocator::Headers.The goal is to have a sort of parallel to the
Vulkan::Headers,Vulkan::HppandVulkan::HppModuletargets.YaaZ/VulkanMemoryAllocator-Hpp would then introduce
VulkanMemoryAllocator::HppandVulkanMemoryAllocator::HppModuletargets to be consistent with the Vulkan targets.It does not break anything and would only really be a cosmetic change, as another ALIAS target already exists (
GPUOpen::VulkanMemoryAllocator). Having the same consistent target relationship between VMA and its Hpp bindings, similar to Vulkan and Vulkan-Hpp bindings, would be great!